Re: pgcrypto: Remove explicit hex encoding/decoding from tests

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgcrypto: Remove explicit hex encoding/decoding from tests
Date: 2021-12-03 15:48:07
Message-ID: 96135e2a-82e1-c432-c572-0f5c4adf5d00@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02.12.21 19:30, Tom Lane wrote:
> Generally +1, but I see you removed some instances of
>
> --- ensure consistent test output regardless of the default bytea format
> -SET bytea_output TO escape;
>
> I think that the principle still applies that this should work regardless
> of the installation's default bytea format, so I'd recommend putting
>
> -- ensure consistent test output regardless of the default bytea format
> SET bytea_output TO hex;
>
> at the top of each file instead.

pg_regress.c sets bytea_output to hex already.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-12-03 15:50:10 Re: pgcrypto: Remove explicit hex encoding/decoding from tests
Previous Message Peter Geoghegan 2021-12-03 15:39:07 Re: Skip vacuum log report code in lazy_scan_heap() if possible