From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgcrypto: Remove explicit hex encoding/decoding from tests |
Date: | 2021-12-02 18:30:45 |
Message-ID: | 2116430.1638469845@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> pgcrypto tests use encode() and decode() calls to convert to/from hex
> encoding. This was from before the hex format was available in bytea.
> Now we can remove the extra explicit encoding/decoding calls and rely on
> the default output format.
Generally +1, but I see you removed some instances of
--- ensure consistent test output regardless of the default bytea format
-SET bytea_output TO escape;
I think that the principle still applies that this should work regardless
of the installation's default bytea format, so I'd recommend putting
-- ensure consistent test output regardless of the default bytea format
SET bytea_output TO hex;
at the top of each file instead.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Lakhin | 2021-12-02 19:00:00 | Re: Windows: Wrong error message at connection termination |
Previous Message | Tom Lane | 2021-12-02 18:22:13 | Re: Replace uses of deprecated Python module distutils.sysconfig |