| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Brendan Jurd <direvus(at)gmail(dot)com>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [GENERAL] ISO week dates |
| Date: | 2007-02-16 17:17:25 |
| Message-ID: | 961.1171646245@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Andrew Dunstan escribi:
>> Well, the first question is "which table should these tests actually be
>> using, and why?" Then they can be changed or moved as appropriate.
> I just committed my patch before reading this comment. Maybe it was
> rushed.
Yes, it was: you now have two duplicate tests in timestamp.sql, and
no corresponding test in timestamptz.sql. It looks to me like the
submitter intended to be testing timestamp_tbl in the former file
and the same tests against timestamptz_tbl in the latter. Please
recheck the diff and fix.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2007-02-16 17:49:36 | Re: patch adding new regexp functions |
| Previous Message | Peter Eisentraut | 2007-02-16 16:54:47 | Re: patch adding new regexp functions |