Re: elog(DEBUG2 in SpinLocked section.

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: elog(DEBUG2 in SpinLocked section.
Date: 2020-06-02 08:35:48
Message-ID: 959a8e3a-ad6b-bdd8-bbd0-cede464f05e9@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020/06/02 16:15, Kyotaro Horiguchi wrote:
> Hello.
>
> I noticed that UpdateSpillStats calls "elog(DEBUG2" within
> SpinLockAcquire section on MyWalSnd. The lock doesn't protect rb and
> in the first place the rb cannot be modified during the function is
> running.
>
> It should be out of the lock section.

Thanks for the patch! It looks good to me.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-06-02 08:42:37 Re: elog(DEBUG2 in SpinLocked section.
Previous Message Fujii Masao 2020-06-02 08:22:26 Re: Resetting spilled txn statistics in pg_stat_replication