elog(DEBUG2 in SpinLocked section.

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: elog(DEBUG2 in SpinLocked section.
Date: 2020-06-02 07:15:18
Message-ID: 20200602.161518.1399689010416646074.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello.

I noticed that UpdateSpillStats calls "elog(DEBUG2" within
SpinLockAcquire section on MyWalSnd. The lock doesn't protect rb and
in the first place the rb cannot be modified during the function is
running.

It should be out of the lock section.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Move-an-elog-out-of-spin-lock-section.patch text/x-patch 1.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2020-06-02 07:46:55 Re: More tests with USING INDEX replident and dropped indexes
Previous Message Kyotaro Horiguchi 2020-06-02 07:00:19 Re: Resetting spilled txn statistics in pg_stat_replication