Re: ALTER TABLE...ALTER COLUMN vs inheritance

From: Bernd Helmle <mailings(at)oopsware(dot)de>
To: Selena Deckelmann <selenamarie(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER TABLE...ALTER COLUMN vs inheritance
Date: 2010-06-16 12:31:00
Message-ID: 955F56897252563E8FAA8C89@[172.26.14.62]
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

--On 15. Juni 2010 20:51:21 -0700 Selena Deckelmann <selenamarie(at)gmail(dot)com>
wrote:

> Confirmed that this tests fine against commit id
> 0dca7d2f70872a242d4430c4c3aa01ba8dbd4a8c
>
> I also wrote a little test script and verified that it throws an error
> when I try to remove a constraint from the parent table.
>

Thanks for looking at this.

Please note that the main purpose of this patch is to protect *child*
tables against dropping NOT NULL constraints inherited from a parent table.
This could lead to unrestorable dumps formerly.

> Should an explicit test be added for this?
>

I think so, yes.

> There are some spelling and grammar errors in comments that I can help
> fix if you want the help.

You're welcome. I have pushed my branch to my git repos as well, if you
like to start from there:

<http://git.postgresql.org/gitweb?p=bernd_pg.git;a=shortlog;h=refs/heads/notnull_constraint>

--
Thanks

Bernd

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2010-06-16 12:37:09 Re: [v9.1] Add security hook on initialization of instance
Previous Message Cédric Villemain 2010-06-16 11:05:42 Re: New PGXN Extension site