| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Improve handling of inherited GENERATED expressions. |
| Date: | 2023-01-12 14:46:00 |
| Message-ID: | 950928.1673534760@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 2023-01-12 Th 08:30, Amit Langote wrote:
>> IIUC, by deciding to not back-patch this, we're expecting the user to
>> fix any child tables in the old cluster that have unsupported (in v16)
>> properties before upgrading to v16, right? If that is indeed the
>> case, maybe this is again a case where TestUpgradeXversion.pm needs
>> tweaking?
> OK, please tell me exactly what I'm meant to tweak :-)
Yeah. I think best bet may be to drop the problematic table(s),
as we've done for other de-supported DDL situations. A quick
experiment suggests that
DROP TABLE gtest_normal_child;
DROP TABLE gtest_normal_child2;
should do it.
I can work on a better-tested patch for TestUpgradeXversion.pm, but
I have a couple other commitments today so it may take a bit of time.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-01-12 15:11:46 | Re: pgsql: Add new GUC createrole_self_grant. |
| Previous Message | Andrew Dunstan | 2023-01-12 14:12:51 | Re: pgsql: Improve handling of inherited GENERATED expressions. |