Re: mcxt.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Gaetano Mendola" <mendola(at)bigfoot(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: mcxt.c
Date: 2003-09-08 13:57:30
Message-ID: 9495.1063029450@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Gaetano Mendola" <mendola(at)bigfoot(dot)com> writes:
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> This seems inappropriate to me. Are you going to suggest that every
>> routine that takes a pointer parameter needs to explicitly test for
>> null?

> Of course I'm not suggesting this, what I'm suggesting is put an
> assert( ) if the test can slow down the performances and an "if ( ) "
> in places that are not going to touch the performances.

I see no value at all in an assert. The code will dump core just fine
with or without an assert ...

regards, tom lane

In response to

  • Re: mcxt.c at 2003-09-08 09:33:52 from Gaetano Mendola

Responses

  • Re: mcxt.c at 2003-09-08 15:09:36 from Gaetano Mendola

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Pflug 2003-09-08 14:14:48 plpgsql debugging
Previous Message Bruno Wolff III 2003-09-08 13:57:05 Re: on-disk format changes

Browse pgsql-patches by date

  From Date Subject
Next Message Gaetano Mendola 2003-09-08 15:09:36 Re: mcxt.c
Previous Message Gaetano Mendola 2003-09-08 13:32:59 Re: mcxt.c