Re: mcxt.c

From: "Gaetano Mendola" <mendola(at)bigfoot(dot)com>
To: <pgsql-hackers(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: mcxt.c
Date: 2003-09-08 15:09:36
Message-ID: 005801c3761b$40028f50$1f720b3e@mm.eutelsat.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Gaetano Mendola" <mendola(at)bigfoot(dot)com> writes:
> > "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> This seems inappropriate to me. Are you going to suggest that every
> >> routine that takes a pointer parameter needs to explicitly test for
> >> null?
>
> > Of course I'm not suggesting this, what I'm suggesting is put an
> > assert( ) if the test can slow down the performances and an "if ( ) "
> > in places that are not going to touch the performances.
>
> I see no value at all in an assert. The code will dump core just fine
> with or without an assert ...

Right but an assert can display information about the file and line number
without debug the application, without mention that reading the code with
the assert is clear what are the precondictions for a call function.

Regards
Gaetano Mendola

In response to

Responses

  • Re: mcxt.c at 2003-09-08 18:32:33 from Neil Conway

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-09-08 15:40:32 plpgsql doesn't coerce boolean expressions to boolean
Previous Message Tom Lane 2003-09-08 14:31:53 Re: FW: indirect dereferencing a field in a record using plpgsql

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-09-08 16:52:01 Re: Minor lmgr code cleanup
Previous Message Tom Lane 2003-09-08 13:57:30 Re: mcxt.c