Inconsistency in installation of syscache_info.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Inconsistency in installation of syscache_info.h
Date: 2026-02-15 19:56:07
Message-ID: 946828.1771185367@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I happened to notice that syscache_info.h is installed into
$installdir/include/server/catalog if you use a non-VPATH
autoconf build, but not if you use a VPATH build or meson.
This is not great IMO.

Just to confuse matters even more, meson builds install a copy of
src/include/catalog/README, which autoconf builds do not.

ISTM we need to get these things in sync.

You could argue that syscache_info.h could never be useful outside the
core server, but it'd be a bit painful to get the non-VPATH code to
not install it, because it just blindly installs everything matching
src/include/catalog/*.h. So I'd vote for making the other two paths
install it too.

I've not looked into why meson is installing a copy of that
README, but it seems quite random to do so, so I'd vote for
not doing that if possible.

Thoughts?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Burd 2026-02-15 20:39:42 Re: Expanding HOT updates for expression and partial indexes
Previous Message Noah Misch 2026-02-15 19:52:39 Re: Buffer locking is special (hints, checksums, AIO writes)