Re: Inconsistency in installation of syscache_info.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Inconsistency in installation of syscache_info.h
Date: 2026-02-16 19:01:38
Message-ID: 1165652.1771268498@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> I happened to notice that syscache_info.h is installed into
> $installdir/include/server/catalog if you use a non-VPATH
> autoconf build, but not if you use a VPATH build or meson.
> This is not great IMO.

> Just to confuse matters even more, meson builds install a copy of
> src/include/catalog/README, which autoconf builds do not.

> ISTM we need to get these things in sync.

Here's a proposed patch for that. I've confirmed we get identical
filesets from all three build methods with this.

Although this seems like clearly a bug, I'm not sure anyone would
thank us for changing the behavior in back branches; particularly
not packagers, who tend to pay close attention to the set of files
installed. So I'm inclined to apply this to master only.

regards, tom lane

Attachment Content-Type Size
0001-synchronize-installed-file-sets.patch text/x-diff 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-02-16 19:11:43 Re: make ExecInsertIndexTuples arguments less bad
Previous Message Pavlo Golub 2026-02-16 19:00:32 Re: [PATCH] Add last_executed timestamp to pg_stat_statements