Re: PATCH: Column Level Privileges

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Column Level Privileges
Date: 2009-02-02 13:33:26
Message-ID: 937d27e10902020533k532f4ee5i1eb35936e97afcfa@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Feb 2, 2009 at 12:55 PM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Dave Page wrote:
>
> - If the dialog is the default (minimum) size when opened, the
> privileges pane does not size correctly. Observed on Windows.
>
> I could not reproduce it on windows (Vista). :(
> Could you please send a screen shot for it?

Attached before and after resize screenshots (it fixes itself if you
resize the dialogue)

> And also found one problem, when privileges are for group, "group " was not
> appended in privileges lists (ctlSecurityPanel). I found the same problem on
> existing privileges dialogs too. :(

Thats intentional - we dropped the 'group' keyword when roles were
introduced. It looks like your patch fixes a related issue with the
incorrect icon being used - we should keep that part of the fix :-)

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Attachment Content-Type Size
image/png 10.1 KB
image/png 10.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2009-02-02 13:46:41 SVN Commit by dpage: r7576 - trunk/pgadmin3/pgadmin/ui
Previous Message Ashesh Vashi 2009-02-02 12:55:07 Re: PATCH: Column Level Privileges