Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.
Date: 2016-10-14 16:43:47
Message-ID: 9212.1476463427@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Oct 14, 2016 at 9:10 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Well, if it has no tests *and* it's not getting installed, what's
>> the point of having it at all?

> It's intended as a demonstration of stuff you could do with background
> workers. Perhaps that begs the question of why Alvaro included it in
> the set of things that got moved from contrib to src/test/modules, but
> I'm still of the opinion that we should build everything in
> src/test/modules when the user does 'make world', whether it has tests
> defined or not.

TBH, I can't muster much sympathy for that position. Make a test case
for it, and the problem goes away, not to mention that confidence in
whether it actually works (not just compiles) goes up a lot.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-10-14 17:49:08 Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.
Previous Message Robert Haas 2016-10-14 16:17:25 Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2016-10-14 16:50:07 Re: Patch to implement pg_current_logfile() function
Previous Message Heikki Linnakangas 2016-10-14 16:24:16 Re: PL/Python adding support for multi-dimensional arrays