Re: Patch to implement pg_current_logfile() function

From: Christoph Berg <myon(at)debian(dot)org>
To: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, "Karl O(dot) Pinc" <kop(at)meme(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to implement pg_current_logfile() function
Date: 2016-10-14 16:50:07
Message-ID: 20161014165007.bzbuzeklsvcr3swh@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Re: To Gilles Darold 2016-10-14 <20161014125406(dot)albrfj3qldiwjnrr(at)msg(dot)df7cb(dot)de>
> A better design might be to return two columns instead:
>
> postgres=# select * from pg_current_logfile();
> stderr | csvlog
> ---------------------------------------+---------------------------------------
> pg_log/postgresql-2016-10-07_1646.log | pg_log/postgresql-2016-10-07_1646.csv

> (The alternative could be to return an extra column:
>
> postgres=# select * from pg_current_logfile();
> type | logfile
> ---------------------------------------
> stderr | pg_log/postgresql-2016-10-07_1646.log
> csvlog | pg_log/postgresql-2016-10-07_1646.csv

Usability-wise it might be better to have pg_current_logfile() just
return the name of the text log (and possibly a HINT that there's a
csv log if stderr is disabled), and have a second function
pg_current_csvlog() return the csv log name.

The choice which design is better will probably depend on if we think
these functions are meant for interactive use (-> 2 functions), or for
automated use (-> 2 columns). My guess would be that interactive use
is more important here.

Christoph

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-10-14 16:51:01 Re: tablesample test failure with small TOAST_TUPLE_THRESHOLD
Previous Message Tom Lane 2016-10-14 16:43:47 Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.