Re: VS 2015 support in src/tools/msvc

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Christian Ullrich <chris(at)chrullrich(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: VS 2015 support in src/tools/msvc
Date: 2016-04-24 15:58:43
Message-ID: 9186.1461513523@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> OK, here's my final version of the patch, which I will apply in 24 hours
> or so unless there is an objection.

> +#pragma warning(push)
> +#pragma warning(disable : 4091)
> #include <dbghelp.h>
> +#pragma warning(pop)

Hmm ... does this pragma work on *every* compiler we're going to use
on Windows? I'm afraid that trying to suppress a warning in VS2015
is going to result in outright failure with other compilers.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-04-24 16:14:40 Re: VS 2015 support in src/tools/msvc
Previous Message Tom Lane 2016-04-24 15:50:01 Re: Defaults for replication/backup