| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Christian Ullrich <chris(at)chrullrich(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: VS 2015 support in src/tools/msvc |
| Date: | 2016-04-24 16:16:11 |
| Message-ID: | 571CF14B.4060005@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/24/2016 11:58 AM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> OK, here's my final version of the patch, which I will apply in 24 hours
>> or so unless there is an objection.
>> +#pragma warning(push)
>> +#pragma warning(disable : 4091)
>> #include <dbghelp.h>
>> +#pragma warning(pop)
> Hmm ... does this pragma work on *every* compiler we're going to use
> on Windows? I'm afraid that trying to suppress a warning in VS2015
> is going to result in outright failure with other compilers.
>
>
According to my research it works on all the MSVC versions we support. I
didn't research the others (i.e. gcc), but we already use the pragma in
float.c without ill effect. Isn't the way #pragma works that compilers
that don't understand the particular pragma are just supposed to ignore it?
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-04-24 16:20:45 | Re: Defaults for replication/backup |
| Previous Message | Tom Lane | 2016-04-24 16:14:40 | Re: VS 2015 support in src/tools/msvc |