Re: pg_proc.dat "proargmodes is not a 1-D char array"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_proc.dat "proargmodes is not a 1-D char array"
Date: 2020-11-17 15:31:53
Message-ID: 916698.1605627113@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Perhaps we can improve these error messages like below. (Or maybe just
> keep it one message "proargmodes is not a 1-D char array of %d
> elements"?) There are about 5 places to change I think.

I doubt that it's really worth expending more code on this.
Certainly I see no reason why that particular test is more likely
to fail than the others, in the presence of corrupt data --- and
I don't want to add individual elog's for each one.

Adding the expected length to the error message might be OK though.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2020-11-17 15:35:25 Re: Additional improvements to extended statistics
Previous Message Victor Yegorov 2020-11-17 15:24:43 Re: Deleting older versions in unique indexes to avoid page splits