| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Proposal: new large object API |
| Date: | 2008-03-20 14:50:53 |
| Message-ID: | 9155.1206024653@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tatsuo Ishii <ishii(at)postgresql(dot)org> writes:
>> Breaking the type_sanity test is not acceptable. Put in a second C
>> function.
> Are you talking opr_sanity?
Sorry, yes, too little caffeine ...
> What is evil with a polymorphic function?
(1) It's creating a false match --- your proposed entry in the opr_sanity
results has nothing at all to do with what the test is looking for.
(2) Refactoring to have two separate C functions will make the code
clearer, and not noticeably longer.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Decibel! | 2008-03-20 15:56:27 | Re: Lazy constraints / defaults |
| Previous Message | Tom Lane | 2008-03-20 14:40:13 | Re: [HACKERS] tsearch2 in postgresql 8.3.1 - invalid byte sequence for encoding "UTF8": 0xc3 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-03-20 17:37:32 | Re: pg_dump --no-tablespaces patch |
| Previous Message | Tatsuo Ishii | 2008-03-20 14:32:53 | Re: Proposal: new large object API |