| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Proposal: new large object API |
| Date: | 2008-03-21 14:38:29 |
| Message-ID: | 20080321.233829.89140968.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
> > What is evil with a polymorphic function?
>
> (1) It's creating a false match --- your proposed entry in the opr_sanity
> results has nothing at all to do with what the test is looking for.
>
> (2) Refactoring to have two separate C functions will make the code
> clearer, and not noticeably longer.
Ok, here is the revised patch.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-03-21 14:41:11 | Re: [Fwd: Re: [PATCHES] 64-bit CommandIds] |
| Previous Message | Simon Riggs | 2008-03-21 14:06:06 | Re: Commit Fest (was Re: Sort Refinement) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | NikhilS | 2008-03-21 14:45:43 | Re: Auto Partitioning Patch - WIP version 1 |
| Previous Message | Simon Riggs | 2008-03-21 14:00:11 | Re: Auto Partitioning Patch - WIP version 1 |