Re: PG 14 release notes, first draft

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG 14 release notes, first draft
Date: 2021-05-11 19:51:39
Message-ID: 904085.1620762699@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Joe Conway <mail(at)joeconway(dot)com> writes:
> On 5/11/21 1:30 PM, Bruce Momjian wrote:
>> It just feels like this change makes the function's behavior less
>> consistent.

> See Tom's commit message here:
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=3d0f68dd30612

> In particular:

> "The variants of these functions that take
> numeric inputs (OIDs or column numbers) are
> supposed to return NULL rather than failing
> on bad input; this rule reduces problems with
> snapshot skew when queries apply the functions
> to all rows of a catalog."

Yeah, the null-return-for-bad-numeric-input behavior is important.
Perhaps a case could be made for returning null for bad text
input too, but I don't recall that anybody has asked for that.

A case could also be made that changing the behavior on the text
side would break applications that expect the current behavior.
So I'm disinclined to make a wholesale change there, without more
evidence that it's a good idea.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-05-11 19:53:06 Re: Why do we have perl and sed versions of Gen_dummy_probes?
Previous Message Andres Freund 2021-05-11 19:47:45 Re: Why do we have perl and sed versions of Gen_dummy_probes?