| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Let's get rid of serial_schedule |
| Date: | 2021-05-11 19:38:55 |
| Message-ID: | 903562.1620761935@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> On 11/05/2021 21:58, Tom Lane wrote:
>> + # for backwards compatibility, interpret "serial" as parallel tests
> This comment isn't great, IMHO. How about:
> # for backwards comopatibility, "serial" runs the tests in
> # parallel_schedule one by one.
Yeah, and on closer inspection, the code is wrong too :-(.
I'd confused --max-concurrent-tests with --max-connections,
but they're different.
Also, I did take a look at pg_regress.c, and confirmed my
fear that getting it to duplicate the serial output style
would be kind of messy.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| delete-serial_schedule-2.patch | text/x-diff | 6.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-05-11 19:44:16 | Re: Let's get rid of serial_schedule |
| Previous Message | Joe Conway | 2021-05-11 19:18:29 | Re: PG 14 release notes, first draft |