| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | d(dot)kovalenko(at)postgrespro(dot)ru, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c) |
| Date: | 2025-09-03 20:10:52 |
| Message-ID: | 901577.1756930252@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)kurilemu(dot)de> writes:
> On 2025-Sep-03, Tom Lane wrote:
>> Hm, I chose that name by analogy to the adjacent
>> confirm_query_canceled(), which is likewise consuming a result.
>> I agree that "consume" is a better verb, but then let's rename
>> confirm_query_canceled as well.
> Ah, that explains it -- my bad, then, I suppose. That change works for
> me.
After reflection, I used "consume_xxx" for the void-returning helper
functions, but kept the "confirm_xxx" terminology for the helper
function that returns a PGresult after confirming its status is
as-expected. Pushed with those renamings.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Sabino Mullane | 2025-09-03 20:54:27 | Re: empty,query_id, pg_stat_activity |
| Previous Message | Andres Freund | 2025-09-03 19:34:36 | Re: BUG #19042: Option --help not recognized at the end of command line in pg_restore |