| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Logical decoding of TRUNCATE |
| Date: | 2018-01-25 12:18:34 |
| Message-ID: | 8ef5c78a-1e98-dce5-82f7-bd0f6eba92e5@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
On 25/01/18 08:26, Thomas Munro wrote:
> On Wed, Jan 24, 2018 at 6:47 AM, Marco Nenciarini
> <marco(dot)nenciarini(at)2ndquadrant(dot)it> wrote:
>> Version 16 attached.
>
> Hi Marco,
>
> FYI this version doesn't compile:
>
> worker.c: In function ‘apply_handle_truncate’:
> worker.c:888:39: error: ‘cascade’ undeclared (first use in this function)
> relid = logicalrep_read_truncate(s, &cascade, &restart_seqs);
> ^
>
Indeed.
We also found one more issue - the truncate done by logical replication
worker is not logically logged which would break cascading.
I expect Marco to send new version shortly with both of these fixed.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marco Nenciarini | 2018-01-25 13:21:15 | Re: [PATCH] Logical decoding of TRUNCATE |
| Previous Message | Durumdara | 2018-01-25 09:38:54 | Re: PGSQL 10, many Random named DB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ildus Kurbangaliev | 2018-01-25 12:26:46 | Re: [PROPOSAL] Shared Ispell dictionaries |
| Previous Message | Etsuro Fujita | 2018-01-25 12:17:00 | Re: list partition constraint shape |