|From:||Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>|
|To:||Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>|
|Cc:||Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: [PROPOSAL] Shared Ispell dictionaries|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Wed, 24 Jan 2018 20:20:41 +0300
Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:
Hi, I did some review of the patch.
In 0001 there are few lines where is only indentation has changed.
- TsearchShmemSize - calculating size using hash_estimate_size seems
redundant since you use DSA hash now.
- ts_dict_shmem_release - LWLockAcquire in the beginning makes no
sense, since dict_table couldn't change anyway.
- ts_dict_shmem_location could return IspellDictData, it makes more
It's very subjective, but I think it would nicer to call option as
Shared (as property of dictionary) or UseSharedMemory, the boolean
option called SharedMemory sounds weird.
Overall the patches look good, all tests passed. I tried to broke it in
few places where I thought it could be unsafe but not succeeded.
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
|Next Message||Alexander Korotkov||2018-01-25 12:26:47||Re: [Patch] Make block and file size for WAL and relations defined at cluster creation|
|Previous Message||Petr Jelinek||2018-01-25 12:18:34||Re: [PATCH] Logical decoding of TRUNCATE|