| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se> |
| Subject: | Re: new clang warnings about unused global variables |
| Date: | 2026-09-11 19:58:42 |
| Message-ID: | 8d5b685f-2b0c-4f25-b853-119487dcbeda@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07.09.26 20:39, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> On 03.09.26 15:52, Tom Lane wrote:
>>> But I concur with Andreas that 0005 looks a bit half-baked.
>>> Maybe that's the right amount of effort for the back branches,
>>> but something else should happen in HEAD.
>
>> Right. Here is another patch at the end (0006) that I propose for
>> master only that makes using unsupported options an error. Some
>> Windows-only options already behaved that way, so this just makes the
>> rest consistent.
>
> With that addition, this looks fine to me.
This has been committed and backpatched. There were a few more issues
of this kind in the backbranches, which I have also fixed.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Cagri Biroglu | 2026-09-11 20:00:07 | Re: Per-table resync for logical replication subscriptions |
| Previous Message | Andres Freund | 2026-09-11 19:51:55 | Re: Init connection time grows quadratically |