Re: new clang warnings about unused global variables

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se>
Subject: Re: new clang warnings about unused global variables
Date: 2026-09-07 18:39:26
Message-ID: 359555.1788806366@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> On 03.09.26 15:52, Tom Lane wrote:
>> But I concur with Andreas that 0005 looks a bit half-baked.
>> Maybe that's the right amount of effort for the back branches,
>> but something else should happen in HEAD.

> Right. Here is another patch at the end (0006) that I propose for
> master only that makes using unsupported options an error. Some
> Windows-only options already behaved that way, so this just makes the
> rest consistent.

With that addition, this looks fine to me.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Tom Lane 2026-09-07 18:20:14 Re: Assert failure in try_nestloop_path()