Re: PATCH: Configurable file mode mask

From: David Steele <david(at)pgmasters(dot)net>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>
Subject: Re: PATCH: Configurable file mode mask
Date: 2018-01-23 14:18:51
Message-ID: 8ca3a7eb-95da-fd32-78d9-888ebc58615b@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/20/18 5:47 PM, Michael Paquier wrote:
> On Fri, Jan 19, 2018 at 06:54:23PM -0300, Alvaro Herrera wrote:
>> Peter Eisentraut wrote:
>> If the only problem is that buildfarm would run tests twice, then I
>> think we should just press forward with this regardless of that: it
>> seems a chicken-and-egg problem, because buildfarm cannot be upgraded to
>> use some new test method if the method doesn't exist yet. As a
>> solution, let's just live with some run duplication for a period until
>> the machines are upgraded to a future buildfarm client code.

It also appears that the TAP tests don't have the infrastructure to be
able to run pg_ugrade properly, per below.

> The main complain I received about this move of the pg_upgrade tests to
> be a TAP one is that they don't support easily cross-major version
> upgrades, removing some abilities to what a developer or the builfarm
> can actually do.

Unless I read it wrong the buildfarm is not doing cross-version
upgrades, but a developer/user can do so manually using the same script?

> Making this possible would require first some
> refactoring of PostgresNode.pm so as a node is aware of the binary paths
> it uses to be able to manipulate multiple instances with different
> install paths at the same time.

Any idea of what the LOE would be for that?

Thanks,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-01-23 14:26:53 Re: PATCH: Configurable file mode mask
Previous Message Simon Riggs 2018-01-23 14:16:36 Re: Logical Decoding and HeapTupleSatisfiesVacuum assumptions