| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactoring SysCacheGetAttr to know when attr cannot be NULL |
| Date: | 2023-03-01 20:34:11 |
| Message-ID: | 8E5B7C1F-84AF-4159-A54B-CA2B07D639BB@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 1 Mar 2023, at 21:04, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>> Yes please!
>
>> I have occasionally wondered whether just passing the isnull argument as
>> NULL would be sufficient, so we don't need a new function.
>
> I thought about that too. I think I prefer Daniel's formulation
> with the new function, but I'm not especially set on that.
I prefer the new function since the name makes the code self documented rather
than developers not used to the API having to look up what the last NULL
actually means.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gregory Stark (as CFM) | 2023-03-01 20:48:42 | Re: File descriptors in exec'd subprocesses |
| Previous Message | Greg Stark | 2023-03-01 20:31:06 | Re: [HACKERS] make async slave to wait for lsn to be replayed |