| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Hint and detail punctuation |
| Date: | 2018-12-06 08:42:26 |
| Message-ID: | 8CC5E919-679E-413E-8442-BF41B0E469D8@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 6 Dec 2018, at 05:46, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Dec 05, 2018 at 05:22:25PM +0100, Daniel Gustafsson wrote:
>> While looking at error messages downstream, I noticed a few hints and details
>> in postgres which aren’t punctuated as per the style guide. The attached patch
>> fixes the ones where it seemed reasonable to end with a period.
>
> Good point. I am spotting a couple more places:
> src/backend/utils/misc/guc.c:
Ah, for some reason I hadn’t thought about looking at the GUCs. I agree with
your findings, patch updated.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| errhint_punctuation-v2.patch | application/octet-stream | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oleksii Kliukin | 2018-12-06 11:26:08 | Re: \gexec \watch |
| Previous Message | Amit Langote | 2018-12-06 08:25:41 | Re: speeding up planning with partitions |