| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Hint and detail punctuation |
| Date: | 2018-12-06 12:44:22 |
| Message-ID: | 20181206124422.eihun33vfajnmupe@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Dec-06, Daniel Gustafsson wrote:
> > On 6 Dec 2018, at 05:46, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > On Wed, Dec 05, 2018 at 05:22:25PM +0100, Daniel Gustafsson wrote:
> >> While looking at error messages downstream, I noticed a few hints and details
> >> in postgres which aren’t punctuated as per the style guide. The attached patch
> >> fixes the ones where it seemed reasonable to end with a period.
> >
> > Good point. I am spotting a couple more places:
> > src/backend/utils/misc/guc.c:
>
> Ah, for some reason I hadn’t thought about looking at the GUCs. I agree with
> your findings, patch updated.
LGTM.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-12-06 12:51:19 | Re: \gexec \watch |
| Previous Message | Pavel Stehule | 2018-12-06 11:52:34 | Re: \gexec \watch |