From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
---|---|
To: | shihao zhong <zhong950419(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fix incorrect PG_GETARG in pgcrypto |
Date: | 2024-02-26 13:47:27 |
Message-ID: | 89cb2998-8b88-4843-9955-ff0bbed5ba0e@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2/16/24 02:35, shihao zhong wrote:
> On Tue, Feb 13, 2024 at 7:08 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>>
>> On Tue, Feb 13, 2024 at 05:36:36PM +0900, Michael Paquier wrote:
>>> You've indeed grabbed some historical inconsistencies here. Please
>>> note that your patch has reversed diffs (for example, the SQL
>>> definition of pgp_sym_encrypt_bytea uses bytea,text,text as arguments
>>> and your resulting patch shows how HEAD does the job with
>>> bytea,bytea,bytea), but perhaps you have generated it with a command
>>> like `git diff -R`?
>>
>> The reversed part of the patch put aside aside, I've double-checked
>> your patch and the inconsistencies seem to be all addressed in this
>> area.
> Thanks for fixing and merging this patch, I appreciate it!
>
Should this be marked as committed, or is there some remaining part?
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2024-02-26 13:54:41 | Re: RFC: Logging plan of the running query |
Previous Message | Amit Kapila | 2024-02-26 13:24:55 | Re: Slow catchup of 2PC (twophase) transactions on replica in LR |