Re: Rename sync_error_count to tbl_sync_error_count in subscription statistics

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: Re: Rename sync_error_count to tbl_sync_error_count in subscription statistics
Date: 2025-11-13 05:18:07
Message-ID: 89825072-9162-485F-8E35-C37EC79D16A1@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Nov 13, 2025, at 11:42, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Nov 13, 2025 at 4:31 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>>
>> CURRENT
>> seq_sync_error_count
>> sync_error_count
>>
>> MY SUGGESTION
>> sync_seq_error_count
>> sync_table_error_count
>>
>
> +1. Along with consistency with other column names, it will also make
> it easier for users to group and query all 'sync' related counts
> together.
>

+1. A common prefix looks good and brings benefits such as what Amit mentioned.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2025-11-13 05:50:33 Re: Suggestion to add --continue-client-on-abort option to pgbench
Previous Message Peter Smith 2025-11-13 05:17:17 DOCS: Missing <structfield> tags for some SEQUENCE fields