| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit |
| Date: | 2022-02-21 16:03:51 |
| Message-ID: | 883589bb-077f-7d66-2406-5f67be0372a6@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022/02/21 14:45, Etsuro Fujita wrote:
> On Fri, Feb 18, 2022 at 1:46 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> I reviewed 0001 patch. It looks good to me except the following minor things. If these are addressed, I think that the 001 patch can be marked as ready for committer.
>
> OK
>
>> + * Also determine to commit (sub)transactions opened on the remote server
>> + * in parallel at (sub)transaction end.
>>
>> Like the comment "Determine whether to keep the connection ...", "determine to commit" should be "determine whether to commit"?
>
> Agreed. I’ll change it as such.
Thanks! If that's updated, IMO it's ok to commit the 0001 patch.
After the commit, I will review 0002 and 0003 patches.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2022-02-21 16:07:07 | Re: Design of pg_stat_subscription_workers vs pgstats |
| Previous Message | Zheng Li | 2022-02-21 15:53:43 | Support logical replication of DDLs |