| From: | Aleksandr Parfenov <a(dot)parfenov(at)postgrespro(dot)ru> |
|---|---|
| To: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
| Cc: | Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: new function for tsquery creartion |
| Date: | 2018-04-01 12:51:03 |
| Message-ID: | 8829c490d0e17b6033b3fd622dfeed1e@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello hackers,
On 2018-03-28 12:21, Aleksander Alekseev wrote:
> It doesn't sound right to me to accept any input as a general rule but
> sometimes return errors nevertheless. That API would be complicated for
> the users. Thus I suggest to accept any garbage and try our best to
> interpret it.
I agree with Aleksander about silencing all errors in
websearch_to_tsquery().
In the attachment is a revised patch with the attempt to introduce an
ability to ignore syntax errors in gettoken_tsvector().
I'm also read through the patch and all the code looks good to me except
one thing.
The name of enum ts_parsestate looks more like a name of the function
than a name of a type.
In my version, it renamed to QueryParserState, but you can fix it if I'm
wrong.
--
Aleksandr Parfenov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| websearch_to_tsquery_v3.diff | text/x-diff | 35.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-04-01 13:39:02 | Re: Add default role 'pg_access_server_files' |
| Previous Message | Konstantin Knizhnik | 2018-04-01 12:48:07 | Diagonal storage model |