Re: new function for tsquery creartion

From: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
To: Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Aleksandr Parfenov <a(dot)parfenov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: new function for tsquery creartion
Date: 2018-03-28 09:21:15
Message-ID: 20180328092115.GA32581@e733.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Dmitry,

> A few gotchas:
> I haven't touched gettoken_tsvector() yet. As a result, the following
> queries produce errors:
> select websearch_to_tsquery('simple', '''');
> ERROR: syntax error in tsquery: "'"
> select websearch_to_tsquery('simple', '\');
> ERROR: there is no escaped character: "\"
> Maybe there's more. The question is: should we fix those, or it's fine as it
> is? I don't have a strong opinion about this.

It doesn't sound right to me to accept any input as a general rule but
sometimes return errors nevertheless. That API would be complicated for
the users. Thus I suggest to accept any garbage and try our best to
interpret it.

Best regards,
Aleksander Alekseev

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-03-28 09:29:26 Re: [HACKERS] path toward faster partition pruning
Previous Message Tatsuo Ishii 2018-03-28 08:39:32 Re: Proposal: http2 wire format