Re: Do CustomScan as not projection capable node

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
Cc: PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Do CustomScan as not projection capable node
Date: 2019-04-19 04:45:04
Message-ID: 8810.1555649104@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> writes:
> Can we include the CustomScan node in the list of nodes that do not
> support projection?

That seems like a pretty bad idea. Maybe it's a good thing for whatever
unspecified extension you have in mind right now, but it's likely to be
a net negative for many more. As an example, if some custom extension has
a better way to calculate some output expression than the core code does,
a restriction like this would prevent that from being implemented.

> Reason is that custom node can contain quite arbitrary logic that does
> not guarantee projection support.

I don't buy this for a minute. Where do you think projection is
going to happen? There isn't any existing node type that *couldn't*
support projection if we insisted that that be done across-the-board.
I think it's mostly just a legacy thing that some don't.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2019-04-19 05:39:26 Re: bug in update tuple routing with foreign partitions
Previous Message Asim R P 2019-04-19 04:38:04 Re: standby recovery fails (tablespace related) (tentative patch and discussion)