Do CustomScan as not projection capable node

From: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
To: PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org>
Subject: Do CustomScan as not projection capable node
Date: 2019-04-19 04:35:44
Message-ID: 0ab0d931-f7b0-d2bc-3089-1954cc21259e@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Can we include the CustomScan node in the list of nodes that do not
support projection?
Reason is that custom node can contain quite arbitrary logic that does
not guarantee projection support.
Secondly. If planner does not need a separate Result node, it just
assign tlist to subplan (i.e. changes targetlist of custom node) and
does not change the custom_scan_tlist.
Perhaps I do not fully understand the logic of using the
custom_scan_tlist field. But if into the PlanCustomPath() routine our
custom node does not build own custom_scan_tlist (may be it will use
tlist as base for custom_scan_tlist) we will get errors in the
set_customscan_references() call.

--
Andrey Lepikhov
Postgres Professional
https://postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
0001-Add-CustomScan-node-in-the-list-of-nodes-that-do-not.patch text/x-patch 767 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Asim R P 2019-04-19 04:38:04 Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Previous Message Amit Langote 2019-04-19 04:17:22 Re: bug in update tuple routing with foreign partitions