Re: pgsql: Make LC_COLLATE and LC_CTYPE database-level settings.

From: Chris Browne <cbbrowne(at)acm(dot)org>
To: pgsql-committers(at)postgresql(dot)org(dot)pgsql-hackers(at)postgresql(dot)org
Cc: Heikki Linnakangas <heikki(at)postgresql(dot)org>
Subject: Re: pgsql: Make LC_COLLATE and LC_CTYPE database-level settings.
Date: 2008-09-24 18:45:09
Message-ID: 87r679qt6y.fsf@dba2.int.libertyrms.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

heikki(at)postgresql(dot)org (Heikki Linnakangas) writes:
> Log Message:
> -----------
> Make LC_COLLATE and LC_CTYPE database-level settings. Collation and
> ctype are now more like encoding, stored in new datcollate and datctype
> columns in pg_database.
>
> This is a stripped-down version of Radek Strnad's patch, with further
> changes by me.
> pgsql/src/bin/pg_dump:
> pg_dump.c (r1.500 -> r1.501)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c?r1=1.500&r2=1.501)
> pg_dumpall.c (r1.106 -> r1.107)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dumpall.c?r1=1.106&r2=1.107)

Let me report a problem with this...

Running pg_dump encounters the following:

chris(at)dba2:Slony-I/CMD/slony1-HEAD/tests> pg_dump -s slonyregress1
pg_dump: column number -1 is out of range 0..7
pg_dump: column number -1 is out of range 0..7
zsh: segmentation fault pg_dump -s slonyregress1

It's not a Slony-I-related issue; I get identical behaviour with other
databases that do not have Slony-I in place.

Things "seem to work" if I roll back this patch to pg_dump.c.

So something's up...
--
(reverse (concatenate 'string "moc.enworbbc" "@" "enworbbc"))
http://www3.sympatico.ca/cbbrowne/emacs.html
"Being really good at C++ is like being really good at using rocks to
sharpen sticks." -- Thant Tessman

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2008-09-24 19:33:16 pgsql: Fix pg_dump bug in the database-level collation patch.
Previous Message Tom Lane 2008-09-24 16:53:07 pgsql: Fix more problems with rewriter failing to set Query.hasSubLinks

Browse pgsql-hackers by date

  From Date Subject
Next Message A.M. 2008-09-24 18:55:10 Re: Proposal of SE-PostgreSQL patches (for CommitFest:Sep)
Previous Message Joshua Drake 2008-09-24 18:43:51 Re: Proposal of SE-PostgreSQL patches (for CommitFest:Sep)