Re: A really subtle lexer bug

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: A really subtle lexer bug
Date: 2018-08-23 18:43:50
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Here's what I will push unless there's something important I missed.

I split the regression tests between create_operator.sql and
polymorphism.sql, because => is really "named argument syntax" rather
than an operator as such, and polymorphism.sql is where the existing
tests were for that.

I tried to keep the three lexers as closely matched as possible, even
though psqlscan.l doesn't actually need some of the changes.

Andrew (irc:RhodiumToad)

Attachment Content-Type Size
0001-Reduce-an-unnecessary-O-N-3-loop-in-lexer.patch text/x-patch 5.0 KB
0002-Fix-lexing-of-standard-multi-character-operators-in-.patch text/x-patch 11.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-08-23 18:53:37 Re: [HACKERS] Optional message to user when terminating/cancelling backend
Previous Message Tom Lane 2018-08-23 18:10:46 Re: [HACKERS] Re: Improve OR conditions on joined columns (common star schema problem)