|From:||ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker )|
|Cc:||PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: [PATCH] Add tab-complete for backslash commands|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
"tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> writes:
> Attached a patch to improve the tab completion for backslash commands.
> I think it’s common for some people(I'm one of them) to use full-name
> commands than abbreviation. So it's more convenient if we can add the
> full-name backslash commands in the tab-complete.c.
Even though I usually use the short versions, I agree that having the
full names in tab the completion as well is a good idea.
> When modify tab-complete.c, I found \dS was added in the
> backslash_commands, but I think maybe it should be removed just like
> other \x[S].
> So I removed it.
> Besides, I also added a little change in help.c.
> - exchange the positon of \des and \det according to alphabetical order
> - rename PATRN1/PATRN2 to ROLEPTRN/DBPTRN to make expression more comprehensible
These are also good changes.
> Any comment is welcome.
> + "\\r", "\\rset",
There's a typo here, that should be "\\reset". Also, I noticed that for
\connect, the situation is the opposite: it has the full form but not
the short form (\c).
I've addressed both in the attached v2 patch.
|Next Message||Dagfinn Ilmari Mannsåker||2021-08-07 23:15:47||Re: perlcritic: prohibit map and grep in void conext|
|Previous Message||Peter Geoghegan||2021-08-07 22:31:49||Re: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE|