Re: perlcritic: prohibit map and grep in void conext

From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker )
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: perlcritic: prohibit map and grep in void conext
Date: 2021-08-07 23:15:47
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker) writes:

> Hi hackers,
> In the patches for improving the MSVC build process, I noticed a use of
> `map` in void context. This is considered bad form, and has a
> perlcritic policy forbidding it:
> Attached is a patch that increases severity of that and the
> corresponding `grep` policy to 5 to enable it in our perlcritic policy,
> and fixes the one use that had already snuck in.

Added to the 2021-09 commitfest:

- ilmari

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-08-07 23:44:07 elog.c query_id support vs shutdown
Previous Message Dagfinn Ilmari Mannsåker 2021-08-07 23:13:14 Re: [PATCH] Add tab-complete for backslash commands