| From: | Gregory Stark <stark(at)enterprisedb(dot)com> |
|---|---|
| To: | "Tom Lane" <tgl(at)postgresql(dot)org> |
| Cc: | <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix a portability bug (ye olde not casting a <ctype.h> argument |
| Date: | 2007-09-17 11:28:34 |
| Message-ID: | 87lkb5o7j1.fsf@oxford.xeocode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
"Tom Lane" <tgl(at)postgresql(dot)org> writes:
> Log Message:
> -----------
> Fix a portability bug (ye olde not casting a <ctype.h> argument to
> unsigned char). Fortunately we still have buildfarm machines that
> will flag this. Seems to be new in CVS HEAD, so no backpatch.
Should we add buildfarm animals which compile with -fsigned-chars and
-funsigned-chars in addition to the per-architecture defaults? Does that
guarantee that we'll trigger this warning or does it not help?
--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User Cunha17 | 2007-09-17 11:59:11 | snapshot - src: Fixing ODBC function names. |
| Previous Message | Gregory Stark | 2007-09-17 11:18:39 | Re: [COMMITTERS] pgsql: Fix up text concatenation so that it accepts all the reasonable |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Markus Schiltknecht | 2007-09-17 13:21:38 | Re: [COMMITTERS] pgsql: Fix up text concatenation so that it accepts all the reasonable |
| Previous Message | Gregory Stark | 2007-09-17 11:18:39 | Re: [COMMITTERS] pgsql: Fix up text concatenation so that it accepts all the reasonable |