| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Fix a portability bug (ye olde not casting a <ctype.h> argument |
| Date: | 2007-09-17 13:33:17 |
| Message-ID: | 21310.1190035997@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> "Tom Lane" <tgl(at)postgresql(dot)org> writes:
>> Fix a portability bug (ye olde not casting a <ctype.h> argument to
>> unsigned char). Fortunately we still have buildfarm machines that
>> will flag this. Seems to be new in CVS HEAD, so no backpatch.
> Should we add buildfarm animals which compile with -fsigned-chars and
> -funsigned-chars in addition to the per-architecture defaults? Does that
> guarantee that we'll trigger this warning or does it not help?
Wouldn't help AFAICS.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-09-17 13:44:21 | Re: [COMMITTERS] pgsql: Fix up text concatenation so that it accepts all the reasonable |
| Previous Message | Gregory Stark | 2007-09-17 13:32:14 | Re: [COMMITTERS] pgsql: Avoid possibly-unportable initializer, per buildfarm warning. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-09-17 13:44:21 | Re: [COMMITTERS] pgsql: Fix up text concatenation so that it accepts all the reasonable |
| Previous Message | Markus Schiltknecht | 2007-09-17 13:21:38 | Re: [COMMITTERS] pgsql: Fix up text concatenation so that it accepts all the reasonable |