Re: draft patch for strtof()

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: draft patch for strtof()
Date: 2019-01-17 23:50:13
Message-ID: 87ef9aj27b.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Andrew" == Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:

Andrew> Because it turns out that Windows (at least the version running
Andrew> on Appveyor) completely fucks this up; strtof() is apparently
Andrew> returning infinity or zero _without setting errno_ for values
Andrew> out of range for float: input of "10e70" returns +inf with no
Andrew> error, input of "10e-70" returns (exactly) 0.0 with no error.

This bug turns out to be dependent on compiler/SDK versions, not
surprisingly. So far I have figured out how to invoke these combinations
on appveyor:

VS2013 / SDK 7.1 (as per cfbot): fails
VS2015 / SDK 8.1: works

Trying to figure out how to get other combinations to test.

--
Andrew (irc:RhodiumToad)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-01-17 23:57:36 Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)
Previous Message Mikael Kjellström 2019-01-17 23:46:45 Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD