Re: draft patch for strtof()

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: draft patch for strtof()
Date: 2019-01-17 02:12:50
Message-ID: 87a7k0jbaq.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

>> (FWIW, I'm running the patch on gaur's host, just to confirm it
>> does what you expect. Should have an answer in an hour or so ...)

Tom> It does --- it compiles cleanly, and the float4 output matches
Tom> float4-misrounded-input.out.

Well I'm glad _something_ works.

Because it turns out that Windows (at least the version running on
Appveyor) completely fucks this up; strtof() is apparently returning
infinity or zero _without setting errno_ for values out of range for
float: input of "10e70" returns +inf with no error, input of "10e-70"
returns (exactly) 0.0 with no error.

*facepalm*

Any windows-users have any idea about this?

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2019-01-17 02:17:45 Re: speeding up planning with partitions
Previous Message David Rowley 2019-01-17 01:45:20 Re: [HACKERS] PATCH: multivariate histograms and MCV lists