| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org> |
| Subject: | Re: ICU for global collation |
| Date: | 2022-01-27 08:10:46 |
| Message-ID: | 87e93704-b7f7-71f6-161d-8713e6334ed3@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21.01.22 17:13, Julien Rouhaud wrote:
> On Fri, Jan 21, 2022 at 03:24:02PM +0100, Peter Eisentraut wrote:
>> On 21.01.22 14:51, Julien Rouhaud wrote:
>>> Is that change intended? There isn't any usage of the collversionstr before
>>> the possible error when actual_versionstr is missing.
>>
>> I wanted to move it closer to the SysCacheGetAttr() where the "datum" value
>> is obtained. It seemed weird to get the datum, then do other things, then
>> decode the datum.
>
> Oh ok. It won't make much difference performance-wise, so no objection.
I have committed this and will provide follow-up patches in the next few
days.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anand Sowmithiran | 2022-01-27 08:21:10 | Re: Output clause for Upsert aka INSERT...ON CONFLICT |
| Previous Message | Kyotaro Horiguchi | 2022-01-27 08:10:42 | Re: Support escape sequence for cluster_name in postgres_fdw.application_name |