Re: ICU for global collation

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org>
Subject: Re: ICU for global collation
Date: 2022-01-21 16:13:31
Message-ID: 20220121161331.xn7fhtfg5j2ucilb@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 21, 2022 at 03:24:02PM +0100, Peter Eisentraut wrote:
> On 21.01.22 14:51, Julien Rouhaud wrote:
> > Is that change intended? There isn't any usage of the collversionstr before
> > the possible error when actual_versionstr is missing.
>
> I wanted to move it closer to the SysCacheGetAttr() where the "datum" value
> is obtained. It seemed weird to get the datum, then do other things, then
> decode the datum.

Oh ok. It won't make much difference performance-wise, so no objection.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2022-01-21 16:29:51 Re: Skipping logical replication transactions on subscriber side
Previous Message Josef Šimánek 2022-01-21 15:38:09 Re: New developer papercut - Makefile references INSTALL