From: | "Joel Jacobson" <joel(at)compiler(dot)org> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: use AV worker items infrastructure for GIN pending list's cleanup |
Date: | 2021-05-15 06:12:51 |
Message-ID: | 87cd65ef-3ac0-48be-bdc6-66253011308e@www.fastmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Apr 5, 2021, at 16:47, Jaime Casanova wrote:
> On Mon, Apr 05, 2021 at 10:41:22AM -0300, Euler Taveira wrote:
> > On Mon, Apr 5, 2021, at 3:31 AM, Jaime Casanova wrote:
> > > When AV worker items where introduced 4 years ago, i was suggested that
> > > it could be used for other things like cleaning the pending list of GIN
> > > index when it reaches gin_pending_list_limit instead of making user
> > > visible operation pay the price.
> > >
> > > That never happened though. So, here is a little patch for that.
> > >
> > > Should I add an entry for this on next commitfest?
> > +1. It slipped through the cracks along the years. It is even suggested in the
> > current docs since the fast update support.
> >
> > https://www.postgresql.org/docs/current/gin-tips.html
> >
>
> Interesting, that comment maybe needs to be rewritten. I would go for
> remove completely the first paragraph under gin_pending_list_limit entry
Thanks for working on this patch.
I found this thread searching for "gin_pending_list_limit" in pg hackers after reading an interesting article found via the front page of Hacker News: "Debugging random slow writes in PostgreSQL" (https://iamsafts.com/posts/postgres-gin-performance/)
I thought it could be interesting to read about a real user story where this patch would be helpful.
Hacker News discussion: https://news.ycombinator.com/item?id=27152507
/Joel
From | Date | Subject | |
---|---|---|---|
Next Message | Fabien COELHO | 2021-05-15 06:41:27 | Re: seawasp failing, maybe in glibc allocator |
Previous Message | Dilip Kumar | 2021-05-15 05:25:05 | Re: Race condition in recovery? |