From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Should contrib modules install .h files? |
Date: | 2018-08-02 17:56:22 |
Message-ID: | 87a7q4adnk.fsf@news-spur.riddles.org.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
Tom> Maybe this all just works without much thought, but given that
Tom> smart people like Peter E. seem to be unsure of that, I'd sure
Tom> like to see a concrete set of rules that extensions should follow
Tom> for this.
I'll comment on the more substantive stuff later since I just noticed a
few relevant points that I need to investigate. But while investigating,
I found...
Tom> There's also a question of whether we need to change anything in
Tom> contrib/ so that it plays by whatever rules we set. There's an
Tom> expectation that contrib modules should be buildable with PGXS,
Tom> so they need to follow the rules.
... that at least all of the *_plperl transform modules in contrib/ fail
to build with USE_PGXS already (i.e. for as long as they have ever
existed), because they rely on plperl_helpers.h which is never installed
anywhere, and trying to get it via $(top_srcdir) obviously can't work in
PGXS.
Haven't tried the python ones yet.
--
Andrew.
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2018-08-02 18:06:20 | Re: [HACKERS] Bug in to_timestamp(). |
Previous Message | Robert Haas | 2018-08-02 17:56:19 | Re: FailedAssertion on partprune |