Re: Packed Varlena Update (v21)

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Packed Varlena Update (v21)
Date: 2007-04-06 09:02:32
Message-ID: 876489kh93.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> I wrote:
>> stark <stark(at)enterprisedb(dot)com> writes:
>>> [ packed varlena patch ]
>
>> Applied with revisions.
>
> Forgot to mention: one of the revisions was to not add the "sizes.sql"
> test, because the output was platform-dependent and is likely to get
> more so if any ability to change the toast thresholds gets put in.
> Can we improve that test to not expose any platform-dependent numbers?

I had imagined that we would have two versions of output files. Other than
32-bit versus 64-bit what other platform-dependent variations enter into it?

I'll look at it again on a 64-bit machine, but probably not for another week.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2007-04-06 10:33:45 Re: Load distributed checkpoint V3
Previous Message Takayuki Tsunakawa 2007-04-06 08:00:47 Re: Load distributed checkpoint V3